chore: generate applyconfigurations for API #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to start our migration to SSA, I am suggesting to generate applyconfigurations using the upstream
applyconfiguration-genfrom https://github.com/kubernetes/code-generator. This tool is a bit user-unfriendly IMO, so a few tweaks to our Go-code is required to make this happen.I have long been waiting for kubernetes-sigs/controller-tools#818 to land, but it seems to take "forever", and there are too many benefits from migrating to SSA to wait any longer. If/when this feature becomes available in controller-gen we can migrate to use it.
Since the generated applyconfigurations are initially going to be used by internal controllers, I suggest to put them in an internal package for now. We can consider making them public later on.